Re: [GSoC] [PATCH v2] t1011: replace test -f with test_path_is_file

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 14, 2022, 16:42 UTC
Message-ID: <xmqqy2071urp.fsf@gitster.g>
In-Reply-To: <CAP8UFD3RtQecxOQWVeapH1CYsMiY2+MoHeugb9bvOsFVnozy=w@mail.gmail.com>

Christian Couder <christian.couder@gmail.com> writes:

> In the commit message it might be nice if there were some explanations
> about why `test_path_is_missing PATH` should be used instead of `!
> test_path_is_file PATH` or `test ! -f PATH` or `! test -f PATH`.

Meaning "the original used '! test -f foo' but what it meant was that it did not want to see 'foo' on the filesystem, regardless of its type, so it should have been '!test -e foo' to begin with"?

I guess it does not hurt, as the original would have passed by mistake if these paths were on the filesystem as directories, but the new code would behave differently, and even if it is a "bugfix", it still is a behaviour change that may be worth explaining.

> The diff part of the patch looks good to me. Thanks!