git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [BUG] test suite broken with GIT_TEST_SPLIT_INDEX

From
Christian Couder <christian.couder@gmail.com>
Date
Apr 21, 2017, 11:57 UTC
Message-ID
<CAP8UFD3MJYR6pH2=7pKjBdLY6oUswNdG7eDNp6PdCFz336Y2FQ@mail.gmail.com>
In-Reply-To
<CAP8UFD2v-X3KfsvFSQrFvgTWRB7P684qN=DowNK2GunJys1i=Q@mail.gmail.com>

On Fri, Apr 21, 2017 at 1:46 PM, Christian Couder <christian.couder@gmail.com> wrote:

Show 33 quoted lines
> On Fri, Apr 21, 2017 at 11:53 AM, Duy Nguyen <pclouds@gmail.com> wrote:
>> On Fri, Apr 21, 2017 at 2:10 PM, Christian Couder
>> <christian.couder@gmail.com> wrote:
>>> On Thu, Apr 20, 2017 at 11:24 PM, Thomas Gummerer <t.gummerer@gmail.com> wrote:
>>>> On 04/20, Christian Couder wrote:
>>>>>
>>>>> Could you try with the following patch:
>>>>>
>>>>> http://public-inbox.org/git/20170330210354.20018-1-chriscool@tuxfamily.org/
>>>>
>>>> Yeah, I tried with and without that patch with the same result.
>>>> Unless I'm screwing something up when testing I don't think this fixes
>>>> the issue unfortunately.
>>>
>>> Ok, I will take a look soon.
>>>
>>> By the way I think that GIT_TEST_SPLIT_INDEX has become redundant now
>>> that there is core.splitIndex.
>>> So perhaps in the long run it will be best to deprecate
>>> GIT_TEST_SPLIT_INDEX and eventually remove it.
>>
>> I think you can't, at least the way I understand this variable. It's a
>> _test_ variable to force exercise split index code path a whole lot
>> more, by running the entire test suite with split index always
>> enabled, instead of just a couple in  t????-split-index.sh. We can't
>> achieve the same with core.splitIndex because that's more about user
>> control and you can't just set core.splitIndex for the entire test
>> suite (can we?).
>
> Yeah, you are right.
> It looks like we have GIT_TEST_OPTS to pass options like --debug,
> --valgrind, --verbose, but we don't have an environment variable to
> set config options.
Or maybe GIT_CONFIG_PARAMETERS works for this purpose?
Previous: Christian CouderNext: Duy Nguyen
Message 7 of 16 in “[BUG] test suite broken with GIT_TEST_SPLIT_INDEX”
  1. Thomas GummererApr 20, 2017
  2. Christian CouderApr 20, 2017
  3. Thomas GummererApr 20, 2017
  4. Christian CouderApr 21, 2017
  5. Duy NguyenApr 21, 2017
  6. Christian CouderApr 21, 2017
  7. Christian CouderApr 21, 2017
  8. Duy NguyenApr 21, 2017
  9. Jeff KingApr 21, 2017
  10. Christian CouderApr 21, 2017
  11. Christian CouderApr 21, 2017
  12. Jeff KingApr 21, 2017
  13. Thomas GummererApr 24, 2017
  14. Junio C HamanoApr 21, 2017
  15. Christian CouderApr 21, 2017
  16. Jeff KingApr 20, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.