Re: [BUG] test suite broken with GIT_TEST_SPLIT_INDEX

From: Jeff King <peff@peff.net>
Date: Apr 21, 2017, 17:09 UTC
Message-ID: <20170421170943.tj5jcstj3yy27sev@sigill.intra.peff.net>
In-Reply-To: <CACsJy8ATvRgOZPpy9_SznvFXm5imJNbcqMSAYSw4H633rqRjEw@mail.gmail.com>

On Fri, Apr 21, 2017 at 07:25:21PM +0700, Duy Nguyen wrote:

Show 13 quoted lines

> >> Yeah, you are right.
> >> It looks like we have GIT_TEST_OPTS to pass options like --debug,
> >> --valgrind, --verbose, but we don't have an environment variable to
> >> set config options.
> >
> > Or maybe GIT_CONFIG_PARAMETERS works for this purpose?
> 
> It has to be set inside test-lib.sh, not from outside because
> environment variables from outside are filtered if I remember
> correctly and only a few specials plus those GIT_TEST_ can survive.
> Some tests override GIT_CONFIG_PARAMETERS themselves to pass config
> vars to certain command (I know because I just did a couple days ago
> ;).which loses core.splitIndex.

It does seem reasonable to have a GIT_TEST_REPO_CONFIG that sets some variables by default in the trash repository created by test_create_repo.

That doesn't quite catch everything, because a few tests make their own sub-repos. But those cases are usually testing something very specific anyway.

-Peff