Re: [BUG] test suite broken with GIT_TEST_SPLIT_INDEX
- From
Christian Couder <christian.couder@gmail.com>
- Date
- Apr 21, 2017, 11:46 UTC
- Message-ID
- <CAP8UFD2v-X3KfsvFSQrFvgTWRB7P684qN=DowNK2GunJys1i=Q@mail.gmail.com>
- In-Reply-To
- <CACsJy8DotVErJjbUBmt9bxu90CSKEsqAT_nYTNXwstEk3YhN2g@mail.gmail.com>
On Fri, Apr 21, 2017 at 11:53 AM, Duy Nguyen <pclouds@gmail.com> wrote:
Show 27 quoted lines
> On Fri, Apr 21, 2017 at 2:10 PM, Christian Couder > <christian.couder@gmail.com> wrote: >> On Thu, Apr 20, 2017 at 11:24 PM, Thomas Gummerer <t.gummerer@gmail.com> wrote: >>> On 04/20, Christian Couder wrote: >>>> >>>> Could you try with the following patch: >>>> >>>> http://public-inbox.org/git/20170330210354.20018-1-chriscool@tuxfamily.org/ >>> >>> Yeah, I tried with and without that patch with the same result. >>> Unless I'm screwing something up when testing I don't think this fixes >>> the issue unfortunately. >> >> Ok, I will take a look soon. >> >> By the way I think that GIT_TEST_SPLIT_INDEX has become redundant now >> that there is core.splitIndex. >> So perhaps in the long run it will be best to deprecate >> GIT_TEST_SPLIT_INDEX and eventually remove it. > > I think you can't, at least the way I understand this variable. It's a > _test_ variable to force exercise split index code path a whole lot > more, by running the entire test suite with split index always > enabled, instead of just a couple in t????-split-index.sh. We can't > achieve the same with core.splitIndex because that's more about user > control and you can't just set core.splitIndex for the entire test > suite (can we?).
Yeah, you are right. It looks like we have GIT_TEST_OPTS to pass options like --debug, --valgrind, --verbose, but we don't have an environment variable to set config options.