Re: [PATCH 9/9] sub-process: do not use strbuf_split*()

From: Christian Couder <christian.couder@gmail.com>
Date: Jul 31, 2025, 08:50 UTC
Message-ID: <CAP8UFD2qAOhRN=b9PB_eXQS1PntZKX95ZK=V4G=10n3iU2xtbw@mail.gmail.com>
In-Reply-To: <20250731074154.2835370-10-gitster@pobox.com>

On Thu, Jul 31, 2025 at 9:44 AM Junio C Hamano <gitster@pobox.com> wrote:

Show 19 quoted lines

>
> The code to read status from subprocess reads one packet line and
> tries to find "status=<foo>".  It is way overkill to split the line
> into an array of two strbufs to extract <foo>.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
>  sub-process.c | 16 +++++++---------
>  1 file changed, 7 insertions(+), 9 deletions(-)
>
> diff --git a/sub-process.c b/sub-process.c
> index 1daf5a9752..de3235c15a 100644
> --- a/sub-process.c
> +++ b/sub-process.c
> @@ -5,6 +5,7 @@
>  #include "sub-process.h"
>  #include "sigchain.h"
>  #include "pkt-line.h"
> +#include "string-list.h"

Is this needed? It looks like skip_prefix() (not any string_list function) is used instead of strbuf_split_str().

Thanks.