[PATCH v2 10/11] trace2: trim_trailing_newline followed by trim is a no-op
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 31, 2025, 22:54 UTC
- Message-ID
- <20250731225433.4028872-11-gitster@pobox.com>
- In-Reply-To
- <20250731225433.4028872-1-gitster@pobox.com>
strbuf_trim_trailing_newline() removes a LF or a CRLF from the tail of a string. If the code plans to call strbuf_trim() immediately after doing so, the code is better off skipping the EOL trimming in the first place. After all, LF/CRLF at the end is a mere special case of whitespaces at the end of the string, which will be removed by strbuf_rtrim() anyway.
Signed-off-by: Junio C Hamano <gitster@pobox.com> --- trace2/tr2_cfg.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/trace2/tr2_cfg.c b/trace2/tr2_cfg.c index 22a99a0682..2b7cfcd10c 100644 --- a/trace2/tr2_cfg.c +++ b/trace2/tr2_cfg.c @@ -39,7 +39,6 @@ static int tr2_cfg_load_patterns(void) if (buf->len && buf->buf[buf->len - 1] == ',') strbuf_setlen(buf, buf->len - 1); - strbuf_trim_trailing_newline(*s); strbuf_trim(*s); } @@ -78,7 +77,6 @@ static int tr2_load_env_vars(void) if (buf->len && buf->buf[buf->len - 1] == ',') strbuf_setlen(buf, buf->len - 1); - strbuf_trim_trailing_newline(*s); strbuf_trim(*s); }
-- 2.50.1-618-g45d530d26b