Re: [PATCH v4 3/8] environment: move `zlib_compression_level` into `struct repo_config_values`

From: Christian Couder <christian.couder@gmail.com>
Date: Jun 2, 2026, 10:08 UTC
Message-ID: <CAP8UFD2J_482vT3J3hYpSeqG+of_ZDjO3a-paGocRyRgn0=FDQ@mail.gmail.com>
In-Reply-To: <ah6QgwfK_TykIiBp@pks.im>

On Tue, Jun 2, 2026 at 10:13 AM Patrick Steinhardt <ps@pks.im> wrote:

Show 9 quoted lines

> Overall, I think it's sensible to always use `the_repository` at the
> callsites in a patch series like this so that it's obvious that there is
> no change in behaviour. So every patch series that gets rid of global
> state in a subsystem X will basically bubble up the global state into
> the next-higher level, and it's then the duty of the next patch series
> to address that next-higher level.
>
> The only exception of course is subsystems that already got rid of
> `the_repository` -- we really shouldn't reintroduce the use there.

I agree that it should be fine to proceed like this. It limits the complexity of the patches when we separate getting rid of `the_repository` from getting rid of other global state.