Re: [PATCH v3 0/8] environment: move core config globals into repo_config_values
- From
Bello Olamide <belkid98@gmail.com>
- Date
- Apr 26, 2026, 00:31 UTC
- Message-ID
- <CAD=f0L8-_3sDGGkCzF4WA0xmUtaY_qiz__3zq5AemLgwTsqvsg@mail.gmail.com>
- In-Reply-To
- <xmqqqzo27fnu.fsf@gitster.g>
On Sun, 26 Apr 2026 at 01:02, Junio C Hamano <gitster@pobox.com> wrote:
Show 21 quoted lines
> > Olamide Caleb Bello <belkid98@gmail.com> writes: > > > Olamide Caleb Bello (8): > > environment: move "trust_ctime" into `struct repo_config_values` > > environment: move "check_stat" into `struct repo_config_values` > > environment: move `zlib_compression_level` into `struct > > repo_config_values` > > environment: move "pack_compression_level" into `struct > > repo_config_values` > > environment: move "precomposed_unicode" into `struct > > repo_config_values` > > env: move "core_sparse_checkout_cone" into `struct repo_config_values` > > env: move "sparse_expect_files_outside_of_patterns" into > > `repo_config_values` > > env: move "warn_on_object_refname_ambiguity" into `struct > > repo_config_values` > > Are there differences between the ones that start with "environment:" > vs the ones with "env:"? >
Hi Junio,
There isn’t any semantic difference intended between the "environment:" and "env:" prefixes
I shortened some of them to stay within the recommended subject length, but on a second thought I agree that consistency is more important here.
I’ll standardize them in the next revision. Thanks.
Show 22 quoted lines
> > > > builtin/cat-file.c | 7 ++++--- > > builtin/fast-import.c | 8 +++++--- > > builtin/index-pack.c | 3 ++- > > builtin/mv.c | 2 +- > > builtin/pack-objects.c | 24 +++++++++++++---------- > > builtin/sparse-checkout.c | 37 +++++++++++++++++++++--------------- > > compat/precompose_utf8.c | 20 +++++++++++++------- > > diff.c | 3 ++- > > dir.c | 3 ++- > > entry.c | 3 ++- > > environment.c | 40 +++++++++++++++++++++------------------ > > environment.h | 19 ++++++++++--------- > > http-push.c | 3 ++- > > object-file.c | 6 ++++-- > > object-name.c | 3 ++- > > revision.c | 7 ++++--- > > sparse-index.c | 4 ++-- > > statinfo.c | 12 +++++++----- > > submodule.c | 7 ++++--- > > upload-pack.c | 3 ++- > > 20 files changed, 126 insertions(+), 88 deletions(-)