Re: [GSoC][PATCH] tests: avoid using pipes

From: Christian Couder <christian.couder@gmail.com>
Date: Mar 10, 2019, 06:05 UTC
Message-ID: <CAP8UFD26Zxt1FvwAajV48eBbhPv_q5oSLTekWxApcNpg=xRn3Q@mail.gmail.com>
In-Reply-To: <20190309154555.33407-1-ttjtftx@gmail.com>

On Sat, Mar 9, 2019 at 4:50 PM Jonathan Chang <ttjtftx@gmail.com> wrote:

>
> This is my attempt for this year's GSoC microproject.

Thanks for being interested in this year's GSoC and doing a microproject.

Show 5 quoted lines

> I copied the commit message of the commit[1] mentioned in the microproject
> page[2]. Is this OK?
>
> Here is a summary of what I did:
>         - simple substitution as in c6f44e1da5[1].

If you take a look at c6f44e1da5 ("t9813: avoid using pipes", 2017-01-04) you can see the following:

    - it changes only one test file: t9813-git-p4-preserve-users.sh
    - its title starts with "t9813: "

It would have been nice if you did the same in your patch (that is only change one test file and start the patch title with the test file number).

On the microproject page, we say:

"Students: Please attempt only ONE microproject. We want quality, not quantity!"

And to other students working on a microproject, we also ask them to focus on only one test file when they make those kinds of changes.

Best, Christian.