[GSoC][PATCH v2 1/5] t0000-basic: fix an indentation error
- From
- Jonathan Chang <ttjtftx@gmail.com>
- Date
- Mar 10, 2019, 08:07 UTC
- Message-ID
- <20190310080739.63984-1-ttjtftx@gmail.com>
- In-Reply-To
- <20190309164508.GB31533@hank.intra.tgummerer.com>
Hi,
Thanks for the reviews.
Here are the changes in the second version: - bug fixes - add preparatory patch - seperate different files to different patch - change to use test_line_count in a seperate patch
Also I found that there is no such function as test_char_count, is it worthwile to add such function? Here are some stat:
`git grep 'test_line_count' | wc -l` = 626 `git grep 'wc -l' | wc -l` = 294 `git grep 'wc -c' | wc -l` = 68
-- >8 --
This is a preparatory step prior to removing the pipes after git commands, which discards git's exit code and may mask a crash.
Signed-off-by: Jonathan Chang <ttjtftx@gmail.com>
diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh index b6566003dd..53821f5817 100755 --- a/t/t0000-basic.sh +++ b/t/t0000-basic.sh @@ -1132,7 +1132,7 @@ test_expect_success 'git commit-tree records the correct parent in a commit' ' test_expect_success 'git commit-tree omits duplicated parent in a commit' ' commit2=$(echo NO | git commit-tree $P -p $commit0 -p $commit0) && - parent=$(git show --pretty=raw $commit2 | + parent=$(git show --pretty=raw $commit2 | sed -n -e "s/^parent //p" -e "/^author /q" | sort -u) && test "z$commit0" = "z$parent" &&
-- 2.21.0