git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[GSoC][PATCH v2 4/5] t0022-crlf-rename: avoid using pipes

From
JCJonathan Chang <ttjtftx@gmail.com>
Date
Mar 10, 2019, 08:10 UTC
Message-ID
<20190310081023.64186-1-ttjtftx@gmail.com>
In-Reply-To
<20190310080931.64134-1-ttjtftx@gmail.com>

The exit code of the upstream in a pipe is ignored thus we should avoid using it. By writing out the output of the git command to a file, we can test the exit codes of both the commands.

Signed-off-by: Jonathan Chang <ttjtftx@gmail.com>
diff --git a/t/t0022-crlf-rename.sh b/t/t0022-crlf-rename.sh
index 7af3fbcc7b..05f443dcce 100755
--- a/t/t0022-crlf-rename.sh
+++ b/t/t0022-crlf-rename.sh
@@ -23,10 +23,10 @@ test_expect_success setup '
 
 test_expect_success 'diff -M' '
 
-	git diff-tree -M -r --name-status HEAD^ HEAD |
-	sed -e "s/R[0-9]*/RNUM/" >actual &&
+	git diff-tree -M -r --name-status HEAD^ HEAD >actual &&
+	sed -e "s/R[0-9]*/RNUM/" actual >output &&
 	echo "RNUM	sample	elpmas" >expect &&
-	test_cmp expect actual
+	test_cmp expect output
 
 '
 
-- 
2.21.0
Previous: Jonathan ChangNext: Jonathan Chang
Message 6 of 20 in “tests: avoid using pipes”
  1. Jonathan ChangMar 9, 2019
  2. Thomas GummererMar 9, 2019
  3. [GSoC][PATCH v2 1/5] t0000-basic: fix an indentation errorJonathan Chang, Mar 10, 2019
  4. [GSoC][PATCH v2 2/5] t0000-basic: avoid using pipesJonathan Chang, Mar 10, 2019
  5. [GSoC][PATCH v2 3/5] t0003-attributes: avoid using pipesJonathan Chang, Mar 10, 2019
  6. [GSoC][PATCH v2 4/5] t0022-crlf-rename: avoid using pipesJonathan Chang, Mar 10, 2019
  7. [GSoC][PATCH v2 5/5] t0000-basic: use test_line_count instead of wc -lJonathan Chang, Mar 10, 2019
  8. Eric SunshineMar 10, 2019
  9. ttjtftxMar 11, 2019
  10. Eric SunshineMar 10, 2019
  11. Eric SunshineMar 10, 2019
  12. jonathan changMar 15, 2019
  13. Thomas GummererMar 10, 2019
  14. jonathan changMar 15, 2019
  15. Christian CouderMar 15, 2019
  16. Christian CouderMar 10, 2019
  17. ttjtftxMar 10, 2019
  18. Christian CouderMar 10, 2019
  19. Fwd: [GSoC][PATCH v2 4/5] t0022-crlf-rename: avoid using pipesttjtftx, Mar 11, 2019
  20. Fwd: [GSoC][PATCH] tests: avoid using pipesjonathan chang, Mar 11, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.