git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-web--browse: recognize iTerm as a GUI terminal on OS X

From
Christian Couder <christian.couder@gmail.com>
Date
Mar 25, 2013, 20:13 UTC
Message-ID
<CAP8UFD21BChC-KF+HWWS9_q_GtpGm+Uh_L60qcJt=b3mQt_jBw@mail.gmail.com>
In-Reply-To
<20130325101318.GA31409@yoda.local>
On Mon, Mar 25, 2013 at 11:13 AM, John Szakmeister <john@szakmeister.net> wrote:
>
> Here's an updated patch.
Thank you for it. For what it's worth:
Acked-by: Christian Couder <chriscool@tuxfamily.org>
Show 5 quoted lines
> I also noticed that git-bisect.sh is
> also trying to determine if a GUI is present by looking for
> SECURITYSESSIONID as well.  I wonder if it would be better to
> create a shell function in git-sh-setup.sh that the two scripts
> could use?

Yeah, it might be a good idea to have some common functions to determine if a GUI is present. Maybe you could start with an os_x_gui_present() function in another patch on top of this one.

Thanks, Christian.

Previous: John SzakmeisterNext: Junio C Hamano
Message 7 of 11 in “Fwd: Bug: git web--browse doesn't recognise browser on OS X”
  1. Timo SandMar 14, 2013
  2. Christian CouderMar 15, 2013
  3. Timo SandMar 22, 2013
  4. John SzakmeisterMar 22, 2013
  5. Christian CouderMar 24, 2013
  6. git-web--browse: recognize iTerm as a GUI terminal on OS XJohn Szakmeister, Mar 25, 2013
  7. Christian CouderMar 25, 2013
  8. Junio C HamanoMar 25, 2013
  9. John SzakmeisterMar 26, 2013
  10. Junio C HamanoMar 27, 2013
  11. John SzakmeisterApr 4, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.