git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-web--browse: recognize iTerm as a GUI terminal on OS X

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 27, 2013, 14:43 UTC
Message-ID
<7vfvzgrjgz.fsf@alter.siamese.dyndns.org>
In-Reply-To
<CAEBDL5Vx0vjAKUeFrXgpx7mYxk8B+OQC5yrEii9RMP-5-Sjhsw@mail.gmail.com>
John Szakmeister <john@szakmeister.net> writes:
Show 14 quoted lines
> Sorry about the repeat Junio, I meant to hit "Reply to All".
>
> On Mon, Mar 25, 2013 at 5:44 PM, Junio C Hamano <gitster@pobox.com> wrote:
> [snip]
>> Your patch makes me wonder if
>>
>>         test -n "$TERM_PROGRAM"
>>
>> without any SECURITYSESSIONID or explicit program name checks should
>> suffice, though.
>
> So, after downloading a couple of other terminals and trying things
> out, I think you're suggestion does suffice.  Should I send an updated
> patch?
If that approach is better than what you originally sent, then yes.

But I do not use OS X, so you may need to pay attention to possible complaints and comments from other Mac users on this list for a while---there may be people who run the program in question without that environment variable.

Previous: John SzakmeisterNext: John Szakmeister
Message 10 of 11 in “Fwd: Bug: git web--browse doesn't recognise browser on OS X”
  1. Timo SandMar 14, 2013
  2. Christian CouderMar 15, 2013
  3. Timo SandMar 22, 2013
  4. John SzakmeisterMar 22, 2013
  5. Christian CouderMar 24, 2013
  6. git-web--browse: recognize iTerm as a GUI terminal on OS XJohn Szakmeister, Mar 25, 2013
  7. Christian CouderMar 25, 2013
  8. Junio C HamanoMar 25, 2013
  9. John SzakmeisterMar 26, 2013
  10. Junio C HamanoMar 27, 2013
  11. John SzakmeisterApr 4, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.