From: Christian Couder <christian.couder@gmail.com>
Date: Mon, 25 Mar 2013 20:13:01 GMT
Subject: Re: [PATCH] git-web--browse: recognize iTerm as a GUI terminal on OS X
Message-ID: <CAP8UFD21BChC-KF+HWWS9_q_GtpGm+Uh_L60qcJt=b3mQt_jBw@mail.gmail.com>
In-Reply-To: <20130325101318.GA31409@yoda.local>

On Mon, Mar 25, 2013 at 11:13 AM, John Szakmeister <john@szakmeister.net> wrote:
>
> Here's an updated patch.

Thank you for it. For what it's worth:

Acked-by: Christian Couder <chriscool@tuxfamily.org>

> I also noticed that git-bisect.sh is
> also trying to determine if a GUI is present by looking for
> SECURITYSESSIONID as well.  I wonder if it would be better to
> create a shell function in git-sh-setup.sh that the two scripts
> could use?

Yeah, it might be a good idea to have some common functions to
determine if a GUI is present.
Maybe you could start with an os_x_gui_present() function in another
patch on top of this one.

Thanks,
Christian.