Re: [PATCH 01/10] promisor-remote: try accepted remotes before others in get_direct()
- From
Christian Couder <christian.couder@gmail.com>
- Date
- Apr 7, 2026, 12:05 UTC
- Message-ID
- <CAP8UFD1iT12ap7_A7Hq1KVPia_mPwqXN7W8Q0atMo0hz3qn8FA@mail.gmail.com>
- In-Reply-To
- <ac4evWK9k69LIV91@pks.im>
On Thu, Apr 2, 2026 at 9:46 AM Patrick Steinhardt <ps@pks.im> wrote:
> > On Thu, Apr 02, 2026 at 09:06:04AM +0200, Christian Couder wrote:
Show 11 quoted lines
> > +test_expect_success "init + fetch two promisors but only one advertised" ' > > + git -C server config promisor.advertise true && > > + test_when_finished "rm -rf client unused_lop" && > > + > > + # Create a promisor that will be configured but not be used > > + git init --bare unused_lop && > > + > > + mkdir client && > > + git -C client init && > > Tiniest nit, not worth rerolling over: this could just be `git init client`.
I copied this from another test, and I didn't think it was worth it to add a preparatory patch just to fix this in the other test, so I left it like this.
It could be a microproject idea to clean things like this in all the test scripts.
Thanks.