[PATCH 04/10] promisor-remote: reject empty name or URL in advertised remote
- From
Christian Couder <christian.couder@gmail.com>
- Date
- Apr 2, 2026, 07:06 UTC
- Message-ID
- <20260402070613.85934-5-christian.couder@gmail.com>
- In-Reply-To
- <20260402070613.85934-1-christian.couder@gmail.com>
In parse_one_advertised_remote(), we check for a NULL remote name and remote URL, but not for empty ones. An empty URL seems possible as url_percent_decode("") doesn't return NULL.
In promisor_config_info_list(), we ignore remotes with empty URLs, so a Git server should not advertise remotes with empty URLs. It's possible that a buggy or malicious server would do it though.
So let's tighten the check in parse_one_advertised_remote() to also reject empty strings at parse time.
Signed-off-by: Christian Couder <chriscool@tuxfamily.org> --- promisor-remote.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/promisor-remote.c b/promisor-remote.c index 8e062ec160..8322349ae8 100644 --- a/promisor-remote.c +++ b/promisor-remote.c @@ -722,7 +722,7 @@ static struct promisor_info *parse_one_advertised_remote(const char *remote_info string_list_clear(&elem_list, 0); - if (!info->name || !info->url) { + if (!info->name || !*info->name || !info->url || !*info->url) { warning(_("server advertised a promisor remote without a name or URL: '%s', " "ignoring this remote"), remote_info); promisor_info_free(info);
-- 2.53.0.765.g57b94de1f0.dirty