[PATCH 00/10] Prepare for advertised remotes auto-configure via URL allowlist
- From
Christian Couder <christian.couder@gmail.com>
- Date
- Apr 2, 2026, 07:06 UTC
- Message-ID
- <20260402070613.85934-1-christian.couder@gmail.com>
Recently, I sent a 16 patch long series that makes it possible for promisor remotes advertised through the "promisor-remote" protocol capability to be auto-configured on the client side via a URL allowlist configured using a new `promisor.acceptFromServerUrl` configuration variable:
https://lore.kernel.org/git/20260323080520.887550-1-christian.couder@gmail.com/
I got the suggestion to split the 16 patches series into two smaller series, starting with a preparatory series. So here is this preparatory series. It's a mix of mostly small fixes, refactorings and cleanups.
High level description of the patches =====================================
- Patches 1-4/10 are fixes:
- Patch 1/10 is the most significant. The others are relatively
small.
- Patch 4/10 is the only new in this series (while all the others
were in the previous series). It prepares for Patch 5/10.- Patches 5-10/10 are refactorings and cleanups:
- Patches 5-7/10 are relatively small independents cleanups or
refactorings. - Patches 8-9/10 are related refactorings simplifying the data
structures used in filter_promisor_remote() and
promisor_remote_reply(). - Patch 10/10 is cleaning up the 'file://' URIs with absolute paths
in the test script.CI tests ========
They all pass, see:
https://github.com/chriscool/git/actions/runs/23848484597
Range-diff ==========
Sorry, no range-diff as I don't think it would be quite useful because the number and order of commits has changed a lot.
Christian Couder (10): promisor-remote: try accepted remotes before others in get_direct() promisor-remote: pass config entry to all_fields_match() directly promisor-remote: clarify that a remote is ignored promisor-remote: reject empty name or URL in advertised remote promisor-remote: refactor should_accept_remote() control flow promisor-remote: refactor has_control_char() promisor-remote: refactor accept_from_server() promisor-remote: keep accepted promisor_info structs alive promisor-remote: remove the 'accepted' strvec t5710: use proper file:// URIs for absolute paths
Documentation/gitprotocol-v2.adoc | 4 + promisor-remote.c | 207 +++++++++++++++----------- t/t5710-promisor-remote-capability.sh | 122 ++++++++++++--- 3 files changed, 223 insertions(+), 110 deletions(-)
-- 2.53.0.765.g57b94de1f0.dirty