Re: [PATCH 1/3] connect: let write_command_and_capabilities() send a promisor-remote reply
- From
Christian Couder <christian.couder@gmail.com>
- Date
- Nov 20, 2026, 16:57 UTC
- Message-ID
- <CAP8UFD1ZDzDvYxF1TjTjBo0SFHfwPdpRrgixRQXN72RxpoJOxw@mail.gmail.com>
- In-Reply-To
- <xmqqh5hkbl6t.fsf@gitster.g>
On Fri, Nov 13, 2026 at 8:11 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 12 quoted lines
> > Christian Couder <christian.couder@gmail.com> writes: > > > They duplicate code for sending "server-option", "agent" and > > "object-format", while each sends a different set of capabilities. > > That is all the more reason to clean them up before we pile more > stuff on top, no? > > I do not know if that deserves to be called "significant" > refactoring, though. It would not take a series with 20 patches > each of which weigh more than 30 lines touched, no?
As you can see in the v2 I just sent, it took 6 refactoring patches instead of 1.
The diffstat is now:
Documentation/gitprotocol-v2.adoc | 7 ++ connect.c | 128 ++++++++++++--------- connect.h | 30 ++++- fetch-object-info.c | 7 +- fetch-pack.c | 23 ++-- t/meson.build | 1 + t/t5705-session-id-in-capabilities.sh | 26 +++++ t/t5710-promisor-remote-capability.sh | 40 +++++++ t/t5711-promisor-remote-capability-http.sh | 126 ++++++++++++++++++++ 9 files changed, 322 insertions(+), 66 deletions(-) create mode 100755 t/t5711-promisor-remote-capability-http.sh
instead of:
Documentation/gitprotocol-v2.adoc | 6 + connect.c | 6 +- connect.h | 6 +- fetch-object-info.c | 3 +- fetch-pack.c | 17 ++- t/meson.build | 1 + t/t5710-promisor-remote-capability.sh | 40 +++++++ t/t5711-promisor-remote-capability-http.sh | 126 +++++++++++++++++++++ 8 files changed, 196 insertions(+), 9 deletions(-) create mode 100755 t/t5711-promisor-remote-capability-http.sh
Thanks.