git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] connect: let write_command_and_capabilities() send a promisor-remote reply

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 12, 2026, 22:18 UTC
Message-ID
<xmqq8q2xhexs.fsf@gitster.g>
In-Reply-To
<20261112195858.53788-6-christian.couder@gmail.com>
Christian Couder <christian.couder@gmail.com> writes:
Show 16 quoted lines
>  void write_command_and_capabilities(struct strbuf *req_buf, const char *command,
> -				    const struct string_list *server_options)
> +				    const struct string_list *server_options,
> +				    const char *promisor_remote_reply)
>  {
>  	const char *hash_name;
>  	int advertise_sid = 0;
> @@ -754,6 +755,9 @@ void write_command_and_capabilities(struct strbuf *req_buf, const char *command,
>  		die(_("the server does not support algorithm '%s'"),
>  		    the_hash_algo->name);
>  	}
> +	if (promisor_remote_reply)
> +		packet_buf_write(req_buf, "promisor-remote=%s",
> +				 promisor_remote_reply);
>  	packet_buf_delim(req_buf);
>  }

This function was designed to have a fairly generic "here we send a command and then capability exchange based on the settings stored in the string list" interface for extensibility. It is highly annoying that we are now adding a specific option here to be sent outside the framework.

Isn't the misdesign being corrected that the "promisor-remote=..." string was not sent as part of these server options list of strings? Can we fix it without contaminating the API like this patch does, or is it too late?

Previous: Christian CouderNext: Junio C Hamano
Message 3 of 8 in “Fix promisor-remote reply missing from fetch”
  1. 0/3 Fix promisor-remote reply missing from fetchChristian Couder, Nov 12, 2026
  2. 1/3 connect: let write_command_and_capabilities() send a promisor-remote replyChristian Couder, Nov 12, 2026
  3. Junio C HamanoNov 12, 2026
  4. Junio C HamanoNov 12, 2026
  5. Christian CouderNov 13, 2026
  6. Junio C HamanoNov 13, 2026
  7. 2/3 fetch-pack: ensure fetch sends a promisor-remote replyChristian Couder, Nov 12, 2026
  8. 3/3 doc: gitprotocol-v2: send the promisor-remote reply with fetchChristian Couder, Nov 12, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.