git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] connect: let write_command_and_capabilities() send a promisor-remote reply

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 13, 2026, 19:11 UTC
Message-ID
<xmqqh5hkbl6t.fsf@gitster.g>
In-Reply-To
<CAP8UFD18rTvM0mu9oSPMd3V+J9GBgc07RM91Pfh4RJqZg0s9aw@mail.gmail.com>
Christian Couder <christian.couder@gmail.com> writes:
> They duplicate code for sending "server-option", "agent" and
> "object-format", while each sends a different set of capabilities.

That is all the more reason to clean them up before we pile more stuff on top, no?

I do not know if that deserves to be called "significant" refactoring, though. It would not take a series with 20 patches each of which weigh more than 30 lines touched, no?

Thanks.
Previous: Christian CouderNext: Christian Couder
Message 6 of 8 in “Fix promisor-remote reply missing from fetch”
  1. 0/3 Fix promisor-remote reply missing from fetchChristian Couder, Nov 12, 2026
  2. 1/3 connect: let write_command_and_capabilities() send a promisor-remote replyChristian Couder, Nov 12, 2026
  3. Junio C HamanoNov 12, 2026
  4. Junio C HamanoNov 12, 2026
  5. Christian CouderNov 13, 2026
  6. Junio C HamanoNov 13, 2026
  7. 2/3 fetch-pack: ensure fetch sends a promisor-remote replyChristian Couder, Nov 12, 2026
  8. 3/3 doc: gitprotocol-v2: send the promisor-remote reply with fetchChristian Couder, Nov 12, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.