Re: [PATCH v4] fast-(import|export): improve on commit signature output format

From: Christian Couder <christian.couder@gmail.com>
Date: Jul 8, 2025, 11:08 UTC
Message-ID: <CAP8UFD1A+eV9hbmp4P3pC71+oSTrtLgxtWGyt++J8a+bk497qA@mail.gmail.com>
In-Reply-To: <aGy82TiRFcij5V_9@pks.im>

On Tue, Jul 8, 2025 at 8:38 AM Patrick Steinhardt <ps@pks.im> wrote:

> I agree with your points. Overall, a fast response cycle is key to good
> collaboration from my point of view. I think it not only makes your life
> as a maintainer easier, but it also makes the reviewer feel like they
> are being heard and is the prerequisite for good discussion.

I don't agree with "is the prerequisite for good discussion". I think it's perfectly possible to have good long running discussions even when people's replies are delayed. And people can have vacations or weekends or private issues or work on other things which can delay some replies. And when people work significantly for a long time on a topic before replying, I really think it can increase the quality of the discussion.

Also if a contributor comes back with improved patches that try to follow closely what a reviewer suggested, then I think it can (and should) make a reviewer feel like they have really been heard better than just a hollow reply right away followed later by less well thought out patches.

This doesn't mean that I think there is no value in a fast response cycle. But I think it depends a lot on the circumstances.

Yeah, for someone new in the community I think it can often help a lot. And I encourage the contributors I mentor to respond soon.

When someone has been part of the community for a long time, I think it's different though. It can happen, but it's much less likely that they are going to disappear tomorrow or otherwise not follow up on feedback they got from reviewers.

It doesn't mean that I think oldtimers should have some kind of privilege, and yeah they should also try to give a good example. But we should allow people to not always behave in a very formatted way. As I mentioned above and in my reply to Junio, many things outside Git development can happen, and people can behave differently, have different preferences in the way they work, and especially not like or want to switch topics very often for example to keep a better mental focus on what they are currently doing.

> On our team's handbook page [1] we have the following couple of bullet
> points regarding how to respond to reviews:

Yeah, I think they are likely to be good for newcomers.