Re: Fwd: [PATCH 4/5] Replace {pre,suf}fixcmp() with {starts,ends}_with()

From: Christian Couder <christian.couder@gmail.com>
Date: Dec 3, 2013, 20:24 UTC
Message-ID: <CAP8UFD0By77QVH1amsh85dX6h1S3iFZcmPzs3JjPZmiD_AmOPQ@mail.gmail.com>
In-Reply-To: <20131203124645.GB26667@sigill.intra.peff.net>

On Tue, Dec 3, 2013 at 1:46 PM, Jeff King <peff@peff.net> wrote:

Show 17 quoted lines

>
> This made it through to me, but not the list. There are at least two
> things going on:
>
>   1. The message is 172K, which is over the 100K limit imposed by vger;
>      the list is silently dropping it.
>
>   2. In my case, the direct mail was being flagged by spam because it
>      contains the blacklisted domain "old.name". Which of course is not
>      a domain at all but rather this code:
>
>        old.name = old.path + strlen("refs/heads/");
>
>      I've tweaked my server.
>
> I can't say why it wasn't getting to Junio via direct mail. Maybe the
> same spam thing, or maybe something else.

[...]

> I skimmed the patch and didn't notice any problems. It's
> whitespace-damaged by gmail, of course. The simplest thing is probably
> to just point us at a public repo with the commit, if you have one.

Ok, the commit is in the use_starts_ends_with branch on this github repo:

https://github.com/chriscool/git.git

Thanks, Christian.