git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Fwd: [PATCH 4/5] Replace {pre,suf}fixcmp() with {starts,ends}_with()

From
Jeff King <peff@peff.net>
Date
Dec 4, 2013, 19:45 UTC
Message-ID
<20131204194515.GA16603@sigill.intra.peff.net>
In-Reply-To
<CAP8UFD0By77QVH1amsh85dX6h1S3iFZcmPzs3JjPZmiD_AmOPQ@mail.gmail.com>
On Tue, Dec 03, 2013 at 09:24:40PM +0100, Christian Couder wrote:
Show 7 quoted lines
> > I skimmed the patch and didn't notice any problems. It's
> > whitespace-damaged by gmail, of course. The simplest thing is probably
> > to just point us at a public repo with the commit, if you have one.
> 
> Ok, the commit is in the use_starts_ends_with branch on this github repo:
> 
> https://github.com/chriscool/git.git

Thanks. I looked more carefully this time, using a few greps to classify the surrounding context (since the script you used for the update could conceivably miss some really odd misuse). The whole thing looks good to me.

-Peff
Previous: Christian CouderNext: Junio C Hamano
Message 13 of 17 in “use starts_with() and ends_with()”
  1. 0/5 use starts_with() and ends_with()Christian Couder, Dec 1, 2013
  2. 1/5 environment: normalize use of prefixcmp() by removing " != 0"Christian Couder, Dec 1, 2013
  3. 2/5 builtin/remote: remove postfixcmp() and use suffixcmp() insteadChristian Couder, Dec 1, 2013
  4. 3/5 strbuf: introduce starts_with() and ends_with()Christian Couder, Dec 1, 2013
  5. 5/5 strbuf: remove prefixcmp() and suffixcmp()Christian Couder, Dec 1, 2013
  6. Jeff KingDec 2, 2013
  7. Junio C HamanoDec 2, 2013
  8. Christian CouderDec 2, 2013
  9. Antoine PelisseDec 2, 2013
  10. Christian CouderDec 3, 2013
  11. Jeff KingDec 3, 2013
  12. Christian CouderDec 3, 2013
  13. Jeff KingDec 4, 2013
  14. Junio C HamanoDec 4, 2013
  15. Junio C HamanoDec 4, 2013
  16. Christian CouderDec 5, 2013
  17. Junio C HamanoDec 5, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.