Re: Fwd: [PATCH 4/5] Replace {pre,suf}fixcmp() with {starts,ends}_with()

From: Jeff King <peff@peff.net>
Date: Dec 3, 2013, 12:46 UTC
Message-ID: <20131203124645.GB26667@sigill.intra.peff.net>
In-Reply-To: <CAP8UFD0jg_Vr7Zf+DiMX9RG6vmmQvmk2NvmL7j=MC-x3fLOOBA@mail.gmail.com>

On Tue, Dec 03, 2013 at 08:03:39AM +0100, Christian Couder wrote:

> I am trying to forward this patch from my gmail address, as it doesn't
> seem to go through when I send it from my home machine.

This made it through to me, but not the list. There are at least two things going on:

  1. The message is 172K, which is over the 100K limit imposed by vger;
     the list is silently dropping it.

  2. In my case, the direct mail was being flagged by spam because it
     contains the blacklisted domain "old.name". Which of course is not
     a domain at all but rather this code:

       old.name = old.path + strlen("refs/heads/");

     I've tweaked my server.

I can't say why it wasn't getting to Junio via direct mail. Maybe the same spam thing, or maybe something else.

Show 18 quoted lines

> From: Christian Couder <chriscool@tuxfamily.org>
> Date: Sun, Dec 1, 2013 at 8:49 AM
> Subject: [PATCH 4/5] Replace {pre,suf}fixcmp() with {starts,ends}_with()
> To: christian.couder@gmail.com
> 
> This patch was generated automatically using the following
> commands:
> 
> git grep --name-only prefixcmp | grep -v '\.h' | grep -v 'strbuf.c' |
> xargs perl -pi -e 's/!prefixcmp\(/starts_with\(/g'
> git grep --name-only prefixcmp | grep -v '\.h' | grep -v 'strbuf.c' |
> xargs perl -pi -e 's/prefixcmp\(/!starts_with\(/g'
> git grep --name-only suffixcmp | grep -v '\.h' | grep -v 'strbuf.c' |
> xargs perl -pi -e 's/!suffixcmp\(/ends_with\(/g'
> git grep --name-only suffixcmp | grep -v '\.h' | grep -v 'strbuf.c' |
> xargs perl -pi -e 's/suffixcmp\(/!ends_with\(/g'
> 
> It was generated on version 1.8.5 of the git codebase.

I skimmed the patch and didn't notice any problems. It's whitespace-damaged by gmail, of course. The simplest thing is probably to just point us at a public repo with the commit, if you have one.

-Peff