git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/4] stash: convert apply to builtin

From
Christian Couder <christian.couder@gmail.com>
Date
Mar 25, 2018, 19:58 UTC
Message-ID
<CAP8UFD04LF68LONP3hxpjc4oQokSab4HYvTkazeBq8STzN6E-A@mail.gmail.com>
In-Reply-To
<CA+CzEk9QpmHK_TSBwQfEedNqrcVSBp3xY7bdv1YA_KxePiFeXw@mail.gmail.com>
On Sun, Mar 25, 2018 at 6:51 PM, Joel Teichroeb <joel@teichroeb.net> wrote:
Show 8 quoted lines
> On Sun, Mar 25, 2018 at 1:09 AM, Christian Couder
> <christian.couder@gmail.com> wrote:
>> It seems to me that the apply_stash() shell function is also used in
>> pop_stash() and in apply_to_branch(). Can the new helper be used there
>> too instead of apply_stash()? And then could apply_stash() be remove?
>
> I wasn't really sure if I should remove code from the .sh file as it
> seems in the past the old .sh files have been kept around as examples.

Yeah, some original shell scripts that have been converted are kept in contrib/examples/, but the shell code has still been removed from the .sh files when they were being converted.

> Has that been done for previous conversions?

I don't think there were some cases when the shell code was not removed. I haven't looked at all the conversions in details though.

Previous: Joel TeichroebNext: Thomas Gummerer
Message 8 of 25 in “Convert some stash functionality to a builtin”
  1. 0/4 Convert some stash functionality to a builtinJoel Teichroeb, Mar 24, 2018
  2. 1/4 stash: convert apply to builtinJoel Teichroeb, Mar 24, 2018
  3. Christian CouderMar 24, 2018
  4. Eric SunshineMar 25, 2018
  5. Christian CouderMar 25, 2018
  6. Christian CouderMar 25, 2018
  7. Joel TeichroebMar 25, 2018
  8. Christian CouderMar 25, 2018
  9. Thomas GummererMar 25, 2018
  10. Joel TeichroebMar 28, 2018
  11. Thomas GummererMar 25, 2018
  12. 2/4 stash: convert branch to builtinJoel Teichroeb, Mar 24, 2018
  13. Eric SunshineMar 25, 2018
  14. Christian CouderMar 25, 2018
  15. Thomas GummererMar 25, 2018
  16. 3/4 stash: convert drop and clear to builtinJoel Teichroeb, Mar 24, 2018
  17. Christian CouderMar 24, 2018
  18. Eric SunshineMar 25, 2018
  19. 4/4 stash: convert pop to builtinJoel Teichroeb, Mar 24, 2018
  20. Eric SunshineMar 25, 2018
  21. Thomas GummererMar 25, 2018
  22. Thomas GummererMar 25, 2018
  23. Remove contrib/examples/*Ævar Arnfjörð Bjarmason, Mar 25, 2018
  24. Jeff KingMar 26, 2018
  25. Junio C HamanoMar 26, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.