Re: [PATCH 1/4] stash: convert apply to builtin

From: Christian Couder <christian.couder@gmail.com>
Date: Mar 25, 2018, 08:09 UTC
Message-ID: <CAP8UFD3Qxt2YMqTtHwU8n7EDvD66QjGSywRQoxJDnncv7=2BUg@mail.gmail.com>
In-Reply-To: <20180324173707.17699-2-joel@teichroeb.net>

On Sat, Mar 24, 2018 at 6:37 PM, Joel Teichroeb <joel@teichroeb.net> wrote:

Show 14 quoted lines

> diff --git a/git-stash.sh b/git-stash.sh
> index fc8f8ae640..92c084eb17 100755
> --- a/git-stash.sh
> +++ b/git-stash.sh
> @@ -711,7 +711,8 @@ push)
>         ;;
>  apply)
>         shift
> -       apply_stash "$@"
> +       cd "$START_DIR"
> +       git stash--helper apply "$@"
>         ;;
>  clear)
>         shift

It seems to me that the apply_stash() shell function is also used in pop_stash() and in apply_to_branch(). Can the new helper be used there too instead of apply_stash()? And then could apply_stash() be remove?