From: Christian Couder Date: Sun, 25 Mar 2018 19:58:59 GMT Subject: Re: [PATCH 1/4] stash: convert apply to builtin Message-ID: In-Reply-To: On Sun, Mar 25, 2018 at 6:51 PM, Joel Teichroeb wrote: > On Sun, Mar 25, 2018 at 1:09 AM, Christian Couder > wrote: >> It seems to me that the apply_stash() shell function is also used in >> pop_stash() and in apply_to_branch(). Can the new helper be used there >> too instead of apply_stash()? And then could apply_stash() be remove? > > I wasn't really sure if I should remove code from the .sh file as it > seems in the past the old .sh files have been kept around as examples. Yeah, some original shell scripts that have been converted are kept in contrib/examples/, but the shell code has still been removed from the .sh files when they were being converted. > Has that been done for previous conversions? I don't think there were some cases when the shell code was not removed. I haven't looked at all the conversions in details though.