Re: [PATCHv2 0/4] git-p4: small fixes to branches and labels; tests

From: Vitor Antunes <vitor.hda@gmail.com>
Date: Nov 30, 2011, 19:44 UTC
Message-ID: <CAOpHH-XQdvdPtj=bCpyFVOLOCPf6+YnEUvk2pLh4sVp0XfvLTw@mail.gmail.com>
In-Reply-To: <4ED6809A.9020703@diamand.org>

On Wed, Nov 30, 2011 at 7:14 PM, Luke Diamand <luke@diamand.org> wrote:

Show 20 quoted lines

> OK, if you can help me understand what's going on...
>
> The label-detection bug that I've described, on further investigation, looks
> to be a fundamental limitation.
>
> With perforce, I can check out the head revision, and then tag just a single
> file. If I then check out on that tag, I get just that one file.
>
> I think I can't do that with git; certainly fast-import can't do it.
>
> So the code in git-p4 that is checking the file vs label counts (git-p4
> around line 1496) is actually trying to say "this label can't be imported
> into git".
>
> If my understanding is correct, I can then fix my test and update the docs
> and the code to explain this.
>
> As an aside, git-p4.txt currently has quite good information on the config
> variables, but nothing on the command line variables. Possibly that should
> be fixed.

Hey Luke,

I did not have any success in the few times I tried to import labels. Since you were updating some of that code I was hoping you could extend git-p4.txt such that I would be able to understand it. This to say: I can't help you much with my current expertise level on how labels are implemented. Will need to look into that later.

-- 
Vitor Antunes