git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv2 0/4] git-p4: small fixes to branches and labels; tests

From
Luke Diamand <luke@diamand.org>
Date
Dec 2, 2011, 08:49 UTC
Message-ID
<4ED89115.6040309@diamand.org>
In-Reply-To
<CAOpHH-XL5OGpnihEgqnXqUUFsMxXn2wSdLadegnC1epg44vs8A@mail.gmail.com>
On 01/12/11 21:59, Vitor Antunes wrote:
Show 9 quoted lines
> On Dec 1, 2011 4:03 AM, "Pete Wyckoff"<pw@padd.com>  wrote:
>> I see your point.  P4 labels are the only way that they support
>> tagging, apparently.  I'm okay with leaving label support in
>> git-p4.  And it will be nice if Luke makes it behave a bit
>> better.  But doing heroics to emulate cross-commit tags feels
>> like a lot of work, and the wrong direction.
>
> Agreed. Lets keep it simple.
>

I think I'm going to have to go away and do a bit more work on this. The existing label code is still quite buggy (or my understanding is broken). Either way I'd rather get it to the point where it actually works and passes all its tests.

The two issues I'm seeing are:
- two p4 labels covering the same set of files; only one of them gets 
imported.
- if you have a p4 label on a subset of files then it gets dropped 
(which is fine) but so do most of the other labels (as far as I can tell).

I think if this could be made to work it would actually be really useful though.

(Pete - I've found your previous email; not sure why I didn't see it before. I'll roll that change in with what I'm doing).

Regards! Luke

Previous: Vitor Antunes
Message 17 of 17 in “[PATCHv2 0/4] git-p4: small fixes to branches and labels; tests”
  1. Luke DiamandNov 30, 2011
  2. 1/4 git-p4: handle p4 branches and labels containing shell charsLuke Diamand, Nov 30, 2011
  3. 2/4 git-p4: cope with labels with empty descriptionsLuke Diamand, Nov 30, 2011
  4. 3/4 git-p4: importing labels should cope with missing ownerLuke Diamand, Nov 30, 2011
  5. 4/4 git-p4: add test for p4 labelsLuke Diamand, Nov 30, 2011
  6. Vitor AntunesNov 30, 2011
  7. Luke DiamandNov 30, 2011
  8. Vitor AntunesNov 30, 2011
  9. Pete WyckoffNov 30, 2011
  10. Pete WyckoffNov 30, 2011
  11. Vitor AntunesDec 1, 2011
  12. Pete WyckoffDec 4, 2011
  13. Luke DiamandDec 1, 2011
  14. Vitor AntunesDec 1, 2011
  15. Pete WyckoffDec 1, 2011
  16. Vitor AntunesDec 1, 2011
  17. Luke DiamandDec 2, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.