[PATCHv2 2/4] git-p4: cope with labels with empty descriptions

From: Luke Diamand <luke@diamand.org>
Date: Nov 30, 2011, 09:03 UTC
Message-ID: <1322643817-13051-3-git-send-email-luke@diamand.org>
In-Reply-To: <1322643817-13051-1-git-send-email-luke@diamand.org>

Use an explicit length for the data in a label, rather than EOT, so that labels with empty descriptions are passed through correctly.

Signed-off-by: Luke Diamand <luke@diamand.org>
---
 contrib/fast-import/git-p4 |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4
index bcac6ec..02f0f54 100755
--- a/contrib/fast-import/git-p4
+++ b/contrib/fast-import/git-p4
@@ -1511,9 +1511,11 @@ class P4Sync(Command, P4UserMap):
                     else:
                         tagger = "%s <a@b> %s %s" % (owner, epoch, self.tz)
                     self.gitStream.write("tagger %s\n" % tagger)
-                    self.gitStream.write("data <<EOT\n")
-                    self.gitStream.write(labelDetails["Description"])
-                    self.gitStream.write("EOT\n\n")
+
+                    description = labelDetails["Description"]
+                    self.gitStream.write("data %d\n" % len(description))
+                    self.gitStream.write(description)
+                    self.gitStream.write("\n")
 
                 else:
                     if not self.silent:

-- 
1.7.8.rc1.209.geac91.dirty