Re: [PATCH v0] fast-import: Add drop command

From: Vitor Antunes <vitor.hda@gmail.com>
Date: Nov 9, 2011, 00:24 UTC
Message-ID: <CAOpHH-X3bgJpRpiJMy-iDDpaFbUy8yZK+GFEwVB2vGHd-GpUiw@mail.gmail.com>
In-Reply-To: <CAGdFq_hSnywznK=3JgWBVigGZmS0ry_WHuuDww5tvPrcsPd7cQ@mail.gmail.com>

Hi Sverre,

Sorry for the late reply.

On Thu, Oct 27, 2011 at 3:36 PM, Sverre Rabbelier <srabbelier@gmail.com> wrote:

> Ok, so the problem is that fast-import notices that a tree that was
> written out as part of a checkpoint is later removed and doesn't like
> that? Shouldn't we just teach the check about trees deleted by the
> drop command?

That was exactly my intention when I used release_tree_entry(). But I guess I'm doing it wrong, because without the delete_ref() part this does not work (just noticed there's a missing semicolon there... sorry). Any advices/guidance, please? :)

-- 
Vitor Antunes