Re: [PATCH v0] fast-import: Add drop command

From: Sverre Rabbelier <srabbelier@gmail.com>
Date: Oct 27, 2011, 14:36 UTC
Message-ID: <CAGdFq_hSnywznK=3JgWBVigGZmS0ry_WHuuDww5tvPrcsPd7cQ@mail.gmail.com>
In-Reply-To: <CAOpHH-W30umoP6CuvrXgiSPBC2NjLvNWUX0uxhU4SU3kBB4H-A@mail.gmail.com>

Heya,

On Thu, Oct 27, 2011 at 13:22, Vitor Antunes <vitor.hda@gmail.com> wrote:

Show 11 quoted lines

> On Thu, Oct 27, 2011 at 12:06 PM, Sverre Rabbelier <srabbelier@gmail.com> wrote:
>> I'm afraid I don't understand why it's a bad thing that fast-import
>> will find the old tree on disk, won't it just be gc-ed if it is no
>> longer used?
>
> No, because fast-import actively checks this to make sure the frontend
> script did not do anything wrong during the import. I think the check
> makes sense and may help debugging a corner case the frontend script
> does not support. So, using "--force" is also not a solution because it
> ignores everything and not only the specific commits I want to leave
> behind.

Ok, so the problem is that fast-import notices that a tree that was written out as part of a checkpoint is later removed and doesn't like that? Shouldn't we just teach the check about trees deleted by the drop command?

-- 
Cheers,

Sverre Rabbelier