Re: [PATCH v0] fast-import: Add drop command
- From
Sverre Rabbelier <srabbelier@gmail.com>
- Date
- Nov 9, 2011, 00:27 UTC
- Message-ID
- <CAGdFq_jPfSFidb59m-5Tsyusw3yQFRnxU9nqBVosVPuzbt86GA@mail.gmail.com>
- In-Reply-To
- <CAOpHH-X3bgJpRpiJMy-iDDpaFbUy8yZK+GFEwVB2vGHd-GpUiw@mail.gmail.com>
Heya,
On Wed, Nov 9, 2011 at 01:24, Vitor Antunes <vitor.hda@gmail.com> wrote:
Show 10 quoted lines
> On Thu, Oct 27, 2011 at 3:36 PM, Sverre Rabbelier <srabbelier@gmail.com> wrote: >> Ok, so the problem is that fast-import notices that a tree that was >> written out as part of a checkpoint is later removed and doesn't like >> that? Shouldn't we just teach the check about trees deleted by the >> drop command? > > That was exactly my intention when I used release_tree_entry(). But I > guess I'm doing it wrong, because without the delete_ref() part this > does not work (just noticed there's a missing semicolon there... > sorry). Any advices/guidance, please? :)
ENODATA. What do you mean with "does not work"? Can you run it through gdb and see what's going on?
-- Cheers, Sverre Rabbelier