Re: send-email and in-reply-to = n
- From
Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
- Date
- Aug 14, 2012, 20:51 UTC
- Message-ID
- <CAOeW2eGZm7PLRaktjQQdDJm2BqAihS0pzsY2GUNFUO83s8qBPQ@mail.gmail.com>
- In-Reply-To
- <7vfw7qbb7y.fsf@alter.siamese.dyndns.org>
On Mon, Aug 13, 2012 at 4:53 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 13 quoted lines
> Stephen Boyd <bebarino@gmail.com> writes: > >> Can we throw up a big warning or just outright fail if someone types >> 'n' or 'y' and hits enter for the in-reply-to question in >> git-send-email? I saw a git-send-email sent patch with an In-Reply-To >> header containing n on lkml today and it makes threading in my mail >> client get confused. > > Yeah, I think it is a good idea to minimally sanity check the answer > to in-reply-to (and possibly other fields); perhaps "does it have @ > and dot" would be a good enough heuristics. > > Please make it so ;-)
And if you do, please include the check for the value for the From: header in the "and possibly other fields". I made the same mistake when asked about that value just a few days ago.