[PATCH] send-email: initial_to and initial_reply_to are both optional
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 6, 2012, 21:21 UTC
- Message-ID
- <7vr4qe26gz.fsf_-_@alter.siamese.dyndns.org>
- In-Reply-To
- <7vipbq3omb.fsf@alter.siamese.dyndns.org>
We may pick up additional recipients from the format-patch output files we are sending, in which case it is perfectly valid to leave the @initial_to empty when the prompt asks. We may want to start a new discussion thread without replying to anything, and it is valid to leave $initial_reply_to empty.
An earlier update to avoid y@example.com stuffed in address fields did not take these two cases into account.
Noticed and fix suggested by Stephen Boyd.
Signed-off-by: Junio C Hamano <gitster@pobox.com> ---
* I am tempted to queue this, after asking you to eyeball it, and then update the author to pass the blame to you before merging it to 'next'.
git-send-email.perl | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl index e89729b..b1fb7e6 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -759,7 +759,8 @@ sub file_declares_8bit_cte { } if (!@initial_to && !defined $to_cmd) { - my $to = ask("Who should the emails be sent to? ", + my $to = ask("Who should the emails be sent to (if any)? ", + default => "", valid_re => qr/\@.*\./, confirm_only => 1); push @initial_to, parse_address_line($to) if defined $to; # sanitized/validated later $prompting++; @@ -786,7 +787,8 @@ sub expand_one_alias { if ($thread && !defined $initial_reply_to && $prompting) { $initial_reply_to = ask( - "Message-ID to be used as In-Reply-To for the first email? ", + "Message-ID to be used as In-Reply-To for the first email (if any)? ", + default => "", valid_re => qr/\@.*\./, confirm_only => 1); } if (defined $initial_reply_to) {
-- 1.7.12.321.g60f00e5