Re: [PATCH] send-email: validate & reconfirm interactive responses

From: Stephen Boyd <bebarino@gmail.com>
Date: Sep 5, 2012, 19:24 UTC
Message-ID: <CALaEz9WVCj0gu-CbUJgydik1bC7z7JCcveKTdyxgrTWokXq5JA@mail.gmail.com>
In-Reply-To: <1344983132-22578-1-git-send-email-gitster@pobox.com>

On Tue, Aug 14, 2012 at 3:25 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 7 quoted lines

> @@ -745,13 +752,15 @@ sub file_declares_8bit_cte {
>  if (!defined $sender) {
>         $sender = $repoauthor || $repocommitter || '';
>         $sender = ask("Who should the emails appear to be from? [$sender] ",
> -                     default => $sender);
> +                     default => $sender,
> +                     valid_re => qr/\@.*\./, confirm_only => 1);

This is now bugging me if I just hit enter and don't want to specify anything for these headers (I want the defaults or what's in the files already). Can we allow the empty string to be valid as well so I don't have to go through these prompts?