Re: [PATCH 05/12] pack-check: stop depending on `the_repository`
Patrick Steinhardt <ps@pks.im> writes:
Show 13 quoted lines
> There are multiple sites in "pack-check.c" where we use the global
> `the_repository` variable, either explicitly or implicitly by using
> `the_hash_algo`. In all of those cases we already have a repository
> available in the calling context though.
>
> Refactor the code to instead use the caller-provided repository and
> remove the `USE_THE_REPOSITORY_VARIABLE` define.
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
> pack-check.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
This was a simple and easy win. Nice.
[snip]
Karthik Nayak <karthik.188@gmail.com>