From: Karthik Nayak <karthik.188@gmail.com>
Date: Thu, 06 Mar 2025 11:14:24 GMT
Subject: Re: [PATCH 05/12] pack-check: stop depending on `the_repository`
Message-ID: <CAOLa=ZTMKF2qvKtVibqAw3d0TnyKrKVD87ntu6p0aKGWYzL7LA@mail.gmail.com>
In-Reply-To: <20250303-b4-pks-objects-without-the-repository-v1-5-c5dd43f2476e@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> There are multiple sites in "pack-check.c" where we use the global
> `the_repository` variable, either explicitly or implicitly by using
> `the_hash_algo`. In all of those cases we already have a repository
> available in the calling context though.
>
> Refactor the code to instead use the caller-provided repository and
> remove the `USE_THE_REPOSITORY_VARIABLE` define.
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
>  pack-check.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
>

This was a simple and easy win. Nice.

[snip]