Re: [PATCH v3 12/12] hash: stop depending on `the_repository` in `null_oid()`
On Mon, Mar 10, 2025 at 12:11 AM Patrick Steinhardt <ps@pks.im> wrote:
>
> On Sat, Mar 08, 2025 at 08:05:09AM -0800, Elijah Newren wrote:
Show 12 quoted lines
> > What you have is an improvement since it's at least making things
> > explicit, but these should really be opt->repo->hash_algo.
>
> Oh, yeah, I suspect that we'll have a bunch of places where we can
> already plug in a repository as available via the context. I typically
> refrain from doing though unless really necessary (e.g. when the file at
> hand doesn't declare `USE_THE_REPOSITORY_VARIABLE` anymore). This is so
> that neither I nor reviewers have to carefully vet every callsite, but
> to make this a mechanical change that is obviously correct because it is
> identical to the old state. So I'm basically leaving it to the next
> patch series that gets rid of `USE_THE_REPOSITORY_VARIABLE` to think
> more carefully about those callsites.
Ah, ok, that makes sense. Thanks for the context.
Elijah Newren <newren@gmail.com>