Re: [PATCH 08/13] tmp-objdir: manage quarantine as an object directory
- From
Karthik Nayak <karthik.188@gmail.com>
- Date
- Oct 6, 2026, 20:18 UTC
- Message-ID
- <CAOLa=ZT7tOCBtd3hHfXgkFaqgMgCt99HquD=hZ7WB0g3PbErKg@mail.gmail.com>
- In-Reply-To
- <20261002-pks-odb-move-alternates-v1-8-8a63507b88c4@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 6 quoted lines
> When creating a quarantine directory via the "tmp-objdir" subsystem we > create a new "files" backend that new objects part of the transaction > can be written to. In a future commit though we'll move handling of > alternates into the "files" backend, and as part of that it will no > longer be possible for us to have multiple sources attached to a single > object database.
I understand the moving of the alternates to the files source, I didn't grasp the need for removal of multiples sources from the object database. Wouldn't it hypothetically make sense to have different sources which use different strategies based on the type of objects?
Show 10 quoted lines
> In a preceding commit, we have prepared the "files" backend to be able > to handle multiple object directories. We don't use that mechanism for > alternates yet, but will start doing so in a subsequent commit. But with > that infrastructure ready we can already migrate tmp-objdirs over to use > this new mechanism. > > Adapt the subsystem so we create a `struct odb_files_dir` instead of a > new "files" source. > > Signed-off-by: Patrick Steinhardt <ps@pks.im>
[snip]
The changes themselves look good to me!