git/list[1] front-page[2] threads[3] people[4] search[5] about
wed 2026-10-07 17:02 UTC

Re: [PATCH 08/13] tmp-objdir: manage quarantine as an object directory

From
Karthik Nayak <karthik.188@gmail.com>
Date
Oct 6, 2026, 20:18 UTC
Message-ID
<CAOLa=ZT7tOCBtd3hHfXgkFaqgMgCt99HquD=hZ7WB0g3PbErKg@mail.gmail.com>
In-Reply-To
<20261002-pks-odb-move-alternates-v1-8-8a63507b88c4@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 6 quoted lines
> When creating a quarantine directory via the "tmp-objdir" subsystem we
> create a new "files" backend that new objects part of the transaction
> can be written to. In a future commit though we'll move handling of
> alternates into the "files" backend, and as part of that it will no
> longer be possible for us to have multiple sources attached to a single
> object database.

I understand the moving of the alternates to the files source, I didn't grasp the need for removal of multiples sources from the object database. Wouldn't it hypothetically make sense to have different sources which use different strategies based on the type of objects?

Show 10 quoted lines
> In a preceding commit, we have prepared the "files" backend to be able
> to handle multiple object directories. We don't use that mechanism for
> alternates yet, but will start doing so in a subsequent commit. But with
> that infrastructure ready we can already migrate tmp-objdirs over to use
> this new mechanism.
>
> Adapt the subsystem so we create a `struct odb_files_dir` instead of a
> new "files" source.
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
[snip]
The changes themselves look good to me!
Previous: Karthik NayakNext: Karthik Nayak
Message 21 of 26 in “odb/source-files: move alternates into the backend”
  1. 00/13 odb/source-files: move alternates into the backendPatrick Steinhardt, Oct 2, 2026
  2. 01/13 commit-graph: require resolved packfile paths for `stdin_packs`Patrick Steinhardt, Oct 2, 2026
  3. 02/13 commit-graph: stop depending on `struct odb_source`Patrick Steinhardt, Oct 2, 2026
  4. 03/13 odb/source-files: introduce `struct odb_files_dir`Patrick Steinhardt, Oct 2, 2026
  5. 04/13 odb: refactor `odb_for_each_alternate()` to yield dirsPatrick Steinhardt, Oct 2, 2026
  6. 05/13 odb: refactor `odb_find_source()` to yield dirsPatrick Steinhardt, Oct 2, 2026
  7. 06/13 odb/source-files: add the ability to have multiple object dirsPatrick Steinhardt, Oct 2, 2026
  8. 07/13 tmp-objdir: absorb logic to set and restore primary sourcesPatrick Steinhardt, Oct 2, 2026
  9. 08/13 tmp-objdir: manage quarantine as an object directoryPatrick Steinhardt, Oct 2, 2026
  10. 09/13 tmp-objdir: replace primary source at creation timePatrick Steinhardt, Oct 2, 2026
  11. 10/13 odb/source: make `will_destroy` an implementation detailPatrick Steinhardt, Oct 2, 2026
  12. 11/13 odb/source-files: extract reading alternatesPatrick Steinhardt, Oct 2, 2026
  13. 12/13 odb/source-files: move alternates into the backendPatrick Steinhardt, Oct 2, 2026
  14. 13/13 odb/source: drop `read_alternates` callbackPatrick Steinhardt, Oct 2, 2026
  15. Karthik NayakOct 5, 2026
  16. Karthik NayakOct 5, 2026
  17. Karthik NayakOct 6, 2026
  18. Patrick SteinhardtOct 6, 2026
  19. Patrick SteinhardtOct 6, 2026
  20. Karthik NayakOct 6, 2026
  21. Karthik NayakOct 6, 2026
  22. Karthik NayakOct 6, 2026
  23. Karthik NayakOct 6, 2026
  24. Karthik NayakOct 6, 2026
  25. Patrick SteinhardtOct 7, 2026
  26. Patrick SteinhardtOct 7, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.