Re: [GSoC PATCH v3 0/2] json-writer: describe the jw_* functions

From: Karthik Nayak <karthik.188@gmail.com>
Date: May 16, 2025, 08:59 UTC
Message-ID: <CAOLa=ZSH4CUdAUOT7H4B+2dwgfx22wJxxjt0SqPavAnEsdkHMA@mail.gmail.com>
In-Reply-To: <20250516010159.27042-1-lucasseikioshiro@gmail.com>

Lucas Seiki Oshiro <lucasseikioshiro@gmail.com> writes:

Show 5 quoted lines

> Hello, again!
>
> In this v3 I did some minor adjustments based on the review of v2
> (https://lore.kernel.org/git/20250512020935.73140-1-lucasseikioshiro@gmail.com/).
>

This version looks good to me, thanks for the update.

I do have some general suggestions (not requirements):
- It would be nice if these patch versions were inlined with the
  previous ones. Makes it easier to compare versions while reviewing.
- Perhaps include a range-diff to make it easier to review the changes
  in the new version compared to the last one.

I can totally recommend b4 (https://b4.docs.kernel.org/en/latest/), it helps manage both of the points I mentioned :)

Show 10 quoted lines

> Lucas Seiki Oshiro (2):
>   json-writer: add docstrings to jw_* functions
>   json-writer: describe the usage of jw_* functions
>
>  json-writer.c |   4 --
>  json-writer.h | 171 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 171 insertions(+), 4 deletions(-)
>
> --
> 2.39.5 (Apple Git-154)