From: Karthik Nayak Date: Fri, 16 May 2025 08:59:22 GMT Subject: Re: [GSoC PATCH v3 0/2] json-writer: describe the jw_* functions Message-ID: In-Reply-To: <20250516010159.27042-1-lucasseikioshiro@gmail.com> Lucas Seiki Oshiro writes: > Hello, again! > > In this v3 I did some minor adjustments based on the review of v2 > (https://lore.kernel.org/git/20250512020935.73140-1-lucasseikioshiro@gmail.com/). > This version looks good to me, thanks for the update. I do have some general suggestions (not requirements): - It would be nice if these patch versions were inlined with the previous ones. Makes it easier to compare versions while reviewing. - Perhaps include a range-diff to make it easier to review the changes in the new version compared to the last one. I can totally recommend b4 (https://b4.docs.kernel.org/en/latest/), it helps manage both of the points I mentioned :) > Lucas Seiki Oshiro (2): > json-writer: add docstrings to jw_* functions > json-writer: describe the usage of jw_* functions > > json-writer.c | 4 -- > json-writer.h | 171 ++++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 171 insertions(+), 4 deletions(-) > > -- > 2.39.5 (Apple Git-154)