Re: [GSoC PATCH v3 0/2] json-writer: describe the jw_* functions

From: Junio C Hamano <gitster@pobox.com>
Date: May 16, 2025, 16:42 UTC
Message-ID: <xmqq7c2gwlqf.fsf@gitster.g>
In-Reply-To: <CAOLa=ZSH4CUdAUOT7H4B+2dwgfx22wJxxjt0SqPavAnEsdkHMA@mail.gmail.com>

Karthik Nayak <karthik.188@gmail.com> writes:

Show 9 quoted lines

> Lucas Seiki Oshiro <lucasseikioshiro@gmail.com> writes:
>
>> Hello, again!
>>
>> In this v3 I did some minor adjustments based on the review of v2
>> (https://lore.kernel.org/git/20250512020935.73140-1-lucasseikioshiro@gmail.com/).
>>
>
> This version looks good to me, thanks for the update.

Yup, the result reads very well.  Thanks, all.

> I do have some general suggestions (not requirements):
> - It would be nice if these patch versions were inlined with the
>   previous ones. Makes it easier to compare versions while reviewing.

"git send-email --in-reply-to=..." is a good tool to use.

> - Perhaps include a range-diff to make it easier to review the changes
>   in the new version compared to the last one.

Here, "git format-patch --range-diff=..." can help when preparing the patches to be sent.

> I can totally recommend b4 (https://b4.docs.kernel.org/en/latest/), it
> helps manage both of the points I mentioned :)

... and more, by helping on the receiving end, too ;-).