git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] bundle: remove unneeded code

From
karthik nayak <karthik.188@gmail.com>
Date
Dec 12, 2024, 10:11 UTC
Message-ID
<CAOLa=ZRKZPWBV2HiVEvt5jm4SCQV_G0k9V0eoHkdnnoUsXGaUA@mail.gmail.com>
In-Reply-To
<20241211-fix-bundle-create-race-v3-1-0587f6f9db1b@iotcl.com>
Toon Claes <toon@iotcl.com> writes:
[snip]
Show 17 quoted lines
> Changes in v3:
> - Remove call to `false` in test that was added during debugging.
> - Link to v2: https://lore.kernel.org/r/20241211-fix-bundle-create-race-v2-1-6a18bd07edec@iotcl.com
>
> Changes in v2:
>
> - No longer user the term "bottomless bundle" and use "full bundle" and
>   "incremental bundle" instead, because they are more commonly used.
>
> - To verify the full bundle created upto tag actually contains the tag
>   object, add a test to clone from the created bundle.
>
> - Explicitly mention in the test names that annotated tags are used,
>   because it's not obvious to see the function test_commit_setvar() used
>   with option `--tag` calls git-tag(1) with `-m` which implies `-a`.
>
> - Link to v1: https://lore.kernel.org/r/20241209-fix-bundle-create-race-v1-1-e6513bdcbf8a@iotcl.com

Had a look at v2 and now v3. So they were annotated tags all along, perfect then. Thanks for the changes, they look good to me.

[snip]
Previous: Toon ClaesNext: Junio C Hamano
Message 6 of 7 in “bundle: remove unneeded code”
  1. bundle: remove unneeded codeToon Claes, Dec 11, 2024
  2. Junio C HamanoDec 11, 2024
  3. Toon ClaesDec 11, 2024
  4. Junio C HamanoDec 12, 2024
  5. bundle: remove unneeded codeToon Claes, Dec 11, 2024
  6. karthik nayakDec 12, 2024
  7. Junio C HamanoDec 13, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.