Re: [PATCH v2] bundle: remove unneeded code

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 11, 2024, 15:07 UTC
Message-ID: <xmqqcyhyi7g7.fsf@gitster.g>
In-Reply-To: <20241211-fix-bundle-create-race-v2-1-6a18bd07edec@iotcl.com>

Toon Claes <toon@iotcl.com> writes:

> - No longer user the term "bottomless bundle" and use "full bundle" and
>   "incremental bundle" instead, because they are more commonly used.

Good.

> - To verify the full bundle created upto tag actually contains the tag
>   object, add a test to clone from the created bundle.

expecting success of 6020.17 'clone from full bundle upto annotated tag':
        git clone --mirror v2.bdl tag-clone.git &&
        git -C tag-clone.git show-ref |
                make_user_friendly_and_stable_output >actual &&
        cat >expect <<-\EOF &&
        <TAG-2> refs/tags/v2
        EOF
        false &&
        test_cmp expect actual

Cloning into bare repository 'tag-clone.git'... Receiving objects: 100% (35/35), done. Resolving deltas: 100% (6/6), done. not ok 17 - clone from full bundle upto annotated tag # # git clone --mirror v2.bdl tag-clone.git && # git -C tag-clone.git show-ref | # make_user_friendly_and_stable_output >actual && # cat >expect <<-\EOF && # <TAG-2> refs/tags/v2 # EOF # false && # test_cmp expect actual # 1..17

What's the "false" doing here?