From: karthik nayak Date: Thu, 12 Dec 2024 10:11:17 GMT Subject: Re: [PATCH v3] bundle: remove unneeded code Message-ID: In-Reply-To: <20241211-fix-bundle-create-race-v3-1-0587f6f9db1b@iotcl.com> Toon Claes writes: [snip] > Changes in v3: > - Remove call to `false` in test that was added during debugging. > - Link to v2: https://lore.kernel.org/r/20241211-fix-bundle-create-race-v2-1-6a18bd07edec@iotcl.com > > Changes in v2: > > - No longer user the term "bottomless bundle" and use "full bundle" and > "incremental bundle" instead, because they are more commonly used. > > - To verify the full bundle created upto tag actually contains the tag > object, add a test to clone from the created bundle. > > - Explicitly mention in the test names that annotated tags are used, > because it's not obvious to see the function test_commit_setvar() used > with option `--tag` calls git-tag(1) with `-m` which implies `-a`. > > - Link to v1: https://lore.kernel.org/r/20241209-fix-bundle-create-race-v1-1-e6513bdcbf8a@iotcl.com Had a look at v2 and now v3. So they were annotated tags all along, perfect then. Thanks for the changes, they look good to me. [snip]