Re: [PATCH 02/10] reftable/stack: inline `stack_compact_range_stats()`

From: karthik nayak <karthik.188@gmail.com>
Date: Aug 22, 2024, 08:23 UTC
Message-ID: <CAOLa=ZQNArqiSaaNHfp_jd1CRsX7-iV4iMyaxG+JUVA5gGj2VA@mail.gmail.com>
In-Reply-To: <3c0cf2bf46f4106d7c0b30c863946262639b2351.1724080006.git.ps@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 7 quoted lines

> The only difference between `stack_compact_range_stats()` and
> `stack_compact_range()` is that the former updates stats on failure,
> whereas the latter doesn't. There are no callers anymore that do not
> want their stats updated though, making the indirection unnecessary.
>
> Inline the stat updates into `stack_compact_range()`.
>

This also ensures that we don't have users who end up using `stack_compact_range()` because they didn't know about `stack_compact_range_stats()`. Which was the case before, I think, I remember one of the compaction function calling `stack_compact_range()` directly. I see it is no longer the case though. Nice.

[snip]