Re: [PATCH v5 0/2] [GSOC]trailer: pass arg as positional parameter
- From
ZheNing Hu <adlternative@gmail.com>
- Date
- Apr 1, 2021, 10:02 UTC
- Message-ID
- <CAOLTT8QxB==BPfwBVex5uof=3EBGdEoTPci7PP1K0mfkQY-5aQ@mail.gmail.com>
- In-Reply-To
- <CAP8UFD0a_HQ9bEQLASn_D1jj+ut+okENJs=aENDxTDL1f2VZKQ@mail.gmail.com>
Christian Couder <christian.couder@gmail.com> 于2021年4月1日周四 下午3:28写道:
Show 26 quoted lines
> > On Wed, Mar 31, 2021 at 12:05 PM ZheNing Hu via GitGitGadget > <gitgitgadget@gmail.com> wrote: > > > > In https://lore.kernel.org/git/xmqqv99i4ck2.fsf@gitster.g/ Junio and > > Christian talked about the problem of using strbuf_replace() to replace > > $ARG. > > It's better to sum up a bit the discussions. It's nice to provide a > link to the discussions though. > > > Now pass trailer value as $1 to the trailer command with another > > trailer.<token>.cmd config. > > If this patch series introduces a new trailer.<token>.cmd config > option, then I would expect one of the patch in the series to have a > subject like "trailer: add new trailer.<token>.cmd config option". > > > ZheNing Hu (2): > > [GSOC] run-command: add shell_no_implicit_args option > > [GSOC]trailer: pass arg as positional parameter > > I guess the "trailer: pass arg as positional parameter" is the one > introducing the new trailer.<token>.cmd config option. > > Also it seems strange that there is no space between "[GSOC]" and "trailer".
Thanks, I'll fix them.
-- ZheNing Hu