Re: [PATCH v6] [GSOC] trailer: add new trailer.<token>.cmd config option

From: ZheNing Hu <adlternative@gmail.com>
Date: Apr 3, 2021, 05:15 UTC
Message-ID: <CAOLTT8Q8J-5xuEfdx5VKyB1WrGjwngdiyPeUEuD8QMnFfSE5mA@mail.gmail.com>
In-Reply-To: <xmqqtuoo0z1l.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> 于2021年4月3日周六 下午12:31写道：

Show 16 quoted lines

>
> ZheNing Hu <adlternative@gmail.com> writes:
>
> > Little bug, Change it like this will work:
> >
> >         } else if (conf->command) {
> >                 strbuf_addstr(&cmd, conf->command);
> > -               strvec_push(&cp.args, cmd.buf);
> >                 if (arg)
> >                         strbuf_replace(&cmd, TRAILER_ARG_STRING, arg);
> > +               strvec_push(&cp.args, cmd.buf);
> >         }
>
> It means the coverage of the test included in this patch was not
> sufficient, right?
>

Indeed, I might have to think what tests need to be added to the ".cmd".

> I queued this separately from the "commit --trailer" topic in
> tonight's pushout, but it may make sense to queue this step
> immediately on top of the "commit --trailer" patch.
>

Maybe I can rebase this "trailer .cmd" to "master" which already have include "commit --trailer" later, this will cover "commit --trailer" tests.

Show 5 quoted lines

> In any case, I suspect we would not hear from Christian right away
> due to timezone differences, so perhaps let this v6 simmer on the
> list, and then hopefully update the documentation part with his
> input.
>

Yes, it's worth waiting patiently,

> Thanks.

Thanks.