Re: [PATCH jx/clean-interactive] t0060: skip a few relative_path tests on Windows

From: Jiang Xin <worldhello.net@gmail.com>
Date: Jun 13, 2013, 09:40 UTC
Message-ID: <CANYiYbHQ307TroSd6Lk=5zg68jdKxGeA4N=hWGfaz1W29NhNVw@mail.gmail.com>
In-Reply-To: <51B98186.2020100@viscovery.net>

2013/6/13 Johannes Sixt <j.sixt@viscovery.net>:

Show 18 quoted lines

> From: Johannes Sixt <j6t@kdbg.org>
>
> The bash on Windows rewrites paths that look like absolute POSIX paths
> when they are a command-line argument of a regular Windows program, such
> as git and the test helpers. As a consequence, the actual tests performed
> are not what the tests scripts expect.
>
> The tests that need *not* be skipped are those where the two paths passed
> to 'test-path-utils relative_path' have the same prefix and the result is
> expected to be a relative path. This is because the rewriting changes
> "/a/b" to "D:/Src/MSysGit/a/b", and when both inputs are extended the same
> way, this just cancels out in the relative path computation.
>
> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
> ---
>  t/t0060-path-utils.sh | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>

Thank you for pointing out this cross-platform issue. I test your patch on Mac OS X, but not test it on msys yet. Since this issue is from the very first commit of this series and this series are still in pu, so I move your patch as patch 02/16 of this series.

You can get the update series in my clone on GitHub:

    $ git remote add jiangxin git://github.com/jiangxin/git.git
    $ git fetch jiangxin jx/clean-interactive
    $ git log --oneline -16 jiangxin/jx/clean-interactive

    c646c test: add t7301 for git-clean--interactive
    92d4a git-clean: add documentation for interactive git-clean
    22e3d git-clean: add ask each interactive action
    5fcb8 git-clean: add select by numbers interactive action
    77ef8e git-clean: add filter by pattern interactive action
    02327 git-clean: use a git-add-interactive compatible UI
    2322 git-clean: add colors to interactive git-clean
    06fad git-clean: show items of del_list in columns
    6ae8b git-clean: add support for -i/--interactive
    1eeb5 git-clean: refactor git-clean into two phases
    3f903 Refactor write_name_quoted_relative, remove unused params
    8ccdf Refactor quote_path_relative, remove unused params
    13da5e quote.c: remove path_relative, use relative_path instead
    1208ee path.c: refactor relative_path(), not only strip prefix
    95b06 t0060: skip a few relative_path tests on Windows
    22247 test: add test cases for relative_path

And commit 95b06 may squash to previous commit 22247.

-- 
Jiang Xin